Skip to content

BUG: Maintain column order in table method rolling #60465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2024
Merged

BUG: Maintain column order in table method rolling #60465

merged 2 commits into from
Dec 3, 2024
+34 −1

Conversation

snitish
Copy link
Member

@snitish snitish commented Dec 2, 2024 •
edited
Loading

@snitish snitish mentioned this pull request Dec 2, 2024
Closed
3 tasks
mroeschke
mroeschke requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a whatsnew note in v3.0.0.rst under the Groupby/resample/rolling section?

@mroeschke mroeschke added the Window rolling, ewma, expanding label Dec 2, 2024
@snitish snitish requested a review from mroeschke December 2, 2024 18:38
@snitish
Copy link
Member Author

snitish commented Dec 2, 2024

Thanks, added note to whatsnew. In general, do we do this even for minor bug fixes?

@mroeschke
Copy link
Member

In general, do we do this even for minor bug fixes?

Yup, especially if the PR fixed an open Github issue

@rhshadrach rhshadrach added Bug Apply Apply, Aggregate, Transform, Map labels Dec 2, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Dec 2, 2024
@mroeschke mroeschke merged commit e631442 into pandas-dev:main Dec 3, 2024
53 of 59 checks passed
@mroeschke
Copy link
Member

Thanks @snitish

@snitish snitish deleted the issue59666 branch February 6, 2025 19:46
KevsterAmp pushed a commit to KevsterAmp/pandas that referenced this pull request Mar 12, 2025
@snitish @KevsterAmp
BUG: Maintain column order in table method rolling (pandas-dev#60465)
cfc55b2 
* BUG: Maintain column order in table method rolling

* BUG: Add bug description to whatsnew/v3.0.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Apply Apply, Aggregate, Transform, Map Bug Window rolling, ewma, expanding

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

BUG: rolling with method='table' and apply sorts columns alphabetically

3 participants

@snitish @mroeschke @rhshadrach